test_runtime.sh: Change --rootfs from '' to '.' #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the spec:
From POSIX:
Also from POSIX:
Also from POSIX:
Support for empty-string paths in the wild seems mixed. Coreutils'
realpath
complains:But Bash's
cp
seems to treat it as.
:In the test script, the use of the empty string comes from c69f4f1
(Modify default root path to "rootfs", 2015-11-13). The change was
likely because the default 'rootfs' isn't useful when runtimetest
needs to read the config.json from the root of the filesystem, so:
doesn't work (because after the pivot runtimetest cannot see
config.json). You could copy the config.json:
but the current test test script just dispenses with the extra
'rootfs' directory:
Why c69f4f1 switched to an empty string instead of
.
is unclear,but I think we should prefer
.
for the POSIX-compliance reasonsoutlined above.
Signed-off-by: W. Trevor King wking@tremily.us